Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_baseline should do better #261

Open
KotlinIsland opened this issue Apr 7, 2022 · 3 comments
Open

auto_baseline should do better #261

KotlinIsland opened this issue Apr 7, 2022 · 3 comments

Comments

@KotlinIsland
Copy link
Owner

KotlinIsland commented Apr 7, 2022

It should be able to update individual files if that file has no errors.

It should respect the config options the baseline was created with, not just the targets.

@DetachHead DetachHead changed the title auto_baseline should be be better auto_baseline should do better Apr 7, 2022
@Zeckie
Copy link

Zeckie commented Apr 24, 2022

It should respect the config options the baseline was created with, not just the targets.

Is that so it doesn't remove errors from the baseline when run with command line switches that reduce strictness?

eg. one time I ran basedmypy with mypy --legacy. It thought that i'd fixed all the errors, and so deleted the baseline.

@Zeckie
Copy link

Zeckie commented Apr 24, 2022

It should be able to update individual files if that file has no errors.

That could be risky in cases where trialling a change in one file to fix one error results in errors in another file. IDEs often have history / undo for changes they make, but often not for files changed externally.

@KotlinIsland
Copy link
Owner Author

It should respect the config options the baseline was created with, not just the targets.

Is that so it doesn't remove errors from the baseline when run with command line switches that reduce strictness?

eg. one time I ran basedmypy with mypy --legacy. It thought that i'd fixed all the errors, and so deleted the baseline.

As a workaround just remember to specify --baseline-file= when using different config options, you could set an alias for this:

> alias --save "mypy-legacy" "mypy --legacy --baseline-file="

That would be covered by #118 and #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants