New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Installation docs to match the tutorial. #357
Conversation
We need to make a long-term decision about how to deal with versioning of docs and code.
The install docs should describe how to install the latest stable version, not Git master. |
This means we'd have to change that with every release, would be nice if we could avoid that. The way I'm doing this in other projects is using As I'm using it everywhere anyway, I'd also recommend it for the Kotti main repo. To be clear: as it's only conventions, no one would be actually required to use it. [1] https://github.com/nvie/gitflow |
This was only a short-term patch to match up installation and tutorial to the new Kotti scaffolding. Long-term, I believe we need a way to install that does not change when versions change. Maybe a link/tag called current that always points to the current release. That way, folks could always get the current release with the same commands. Something like pip install -r https://github.../current/requirements.txt |
Not sure how branch naming or gitflow is related? I also have no idea how |version| was supposed to work before, but is it a template variable? I understand that @cullerton's change is temporary, so it's fine. Let's just not have people install Kotti from the latest bleeding edge in the main install docs, long term. |
Very briefly: with gitflow you have a branch that is always the same as the latest release ( ExampleInitialize the repo to use gitflow:
Do work on master as usual. When master is ready for a new release do:
Do some "last minute changes", such as increasing the version or some other metadata and publish the release to PyPI:
Here comes the real convenience:
The remainder of this comment is just for the sake of completness and doesn't directly relate to the initial topic. gitflow has two more subcommands: one for adding a new Start a new feature:
Work on the feature branch as usual. Either create a pull request when done or merge the feature into master yourself:
Start a new hotfix:
Fix the bug in the hotfix branch, update version number in the package metadata and commit. Then finish the hotfix:
Now either checkout the |
Regarding |
Ah, understood how the gitflow model is related to the change now. My only reservation with gitflow is that may raise the barrier for contributors. It seems like now there's a convention on top of 'normal' git that I have to understand. You'll say that it's just a convention, and that it makes life easier, but honestly I don't know. Willing to go along though if you're willing to regard yourself as the release manager now. :-) It would be great if we could get RTD to publish the latest release instead of master always. |
Nope. Nothing changes at all for contributors. They don't need to use or even know gitflow. You just need to tell it to use different branch names than it suggests (once, upon initialization). I'd also be fine with being release manager, because it's so easy with gitflow. Having a |
Alright, good job with dodging the release manager question. But I'm fine, let's use it if it's that good. ;-) |
Huh, dodging? Not at all! I'd be fine taking over if you want... |
My humor is seemingly getting lost in this bug tracker (if it ever existed), sorry for that. I'd say you're the perfect candidate for the role. :-) |
Update Installation docs to match the tutorial.
Hey Disko,
This branch removes your |version| variable in the Installation docs, and uses the github master branch instead. This allows someone to follow the Installation and Tutorial together.
I'm not sure if you want/need this right now. We need to figure out what to do long-term though.
Do with it what you wish :)
Mike