Clarification of Backup Strategy

[jimmybrancaccio]

Describe the bug

This may or may not be a bug. Looking at config/backup.php I see there appears to be a default backup strategy at the bottom of file, however this configuration does not seem to be obeyed as I currently have 23 backups.

To Reproduce

1. Setup LinkAce, I am currently using the "advanced" Docker deployment.
2. Configure backups w/ S3.
3. Let the backup process take place, and see it continue to occur.
4. Does it ever remove older backups?

Expected behavior

At this point I am not sure what to expect since nothing appears to be documented, except for looking at the backup.php file.

Screenshots

N/A

LinkAce setup (please complete the following information):

• Version: v1.2.2 (though I see there is a new version - not sure if anything in regards to backups was touched in that version)
• Installed via: Docker
• OS: Ubuntu 20.04.x

Desktop (please complete the following information if applicable):

N/A

Smartphone (please complete the following information if applicable):

N/A

Additional context

N/A

[Kovah]

You can find more details about application backups in the Laravel-Backup Package by spatie, which provides the feature: https://spatie.be/docs/laravel-backup/v6/introduction

[jimmybrancaccio]

Ok, so it's just a matter of running php artisan to clean things up.

[Kovah]

If you have set up the cron as explained in the documentation, this command should already be run every night. Could you check that?

[jimmybrancaccio]

@Kovah Yes, the cron is already configured.

[Kovah]

As LinkAce ships with the default configuration of the package, daily backups of the last 7 days are kept. Are older ones deleted or do you have one on storage?

[jimmybrancaccio]

@Kovah It appears no backups are deleted. S3 bucket listing:

I get 2 emails daily, subjects and contents:

backup::notifications.cleanup_successful_subject

backup::notifications.backup_successful_subject

[Kovah]

Okay thanks. Will take a look.

[Kovah]

@jimmybrancaccio BTW Did running the clean command manually help?

[jimmybrancaccio]

@Kovah I've just run php artisan backup:clean now, but it doesn't seem to have done anything:

root@0feb3d037594:/app# php artisan backup:clean
Starting cleanup...
Cleaning backups of LinkAce on disk s3...
Used storage after cleanup: 29.64 MB.
Cleanup completed!

[Kovah]

That's super weird. Have to investigate this.

[Kovah]

I have set up backups on my personal LinkAce, but currently not even the backups are created despite having the backups enabled. no idea what's wrong with that.

[jimmybrancaccio]

Oddly enough mine seem to be rotating now and it seems to keep 27 backups. 🤷🏼

[Kovah]

I found that I had broken my cron job, backups are running now.
Did you upgrade in the last days?

[jimmybrancaccio]

I believe I did an upgrade last week. I am on 1.5.0 and the UI notes there's no other upgrades.

[Kovah]

Maybe it was a bug in the used package and it was resolved with version 1.5. Well... At least it's working. 🥳
Will monitor this on my personal setup.

[jimmybrancaccio]

Yeah definitely possible. That said, this should probably be documented.