Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces in tags for import parser #333

Closed
Fivefold opened this issue Dec 12, 2021 · 3 comments
Closed

Support spaces in tags for import parser #333

Fivefold opened this issue Dec 12, 2021 · 3 comments
Labels
Enhancement Any requests for improvements or new features

Comments

@Fivefold
Copy link

Is your feature request related to a problem? Please describe.
LinkAce supports spaces in tags (e.g. "my tag") and uses commas as separator. The importer considers both commas and spaces as separator, so if you had a link in your exported bookmarks like this:

<DT><A HREF="http://testlink.test/" ADD_DATE="1468778724" TAGS="test tag1,test_tag2">Testlink</A>

it would import with the tags test, tag1 and test_tag2

Describe the solution you'd like
Support spaces in tags, since LinkAce itself supports them.

Describe alternatives you've considered
Putting the spaces in Apostrophes in the imported .html file (i.e. TAGS="'test tag1','test_tag2'"> gets imported as 'test', 'tag1' and 'test_tag2'

Additional context
This seems to be related to the used shaarli bookmark parser (see sebsauvage/Shaarli#22).

@Fivefold Fivefold added the Enhancement Any requests for improvements or new features label Dec 12, 2021
@Kovah
Copy link
Owner

Kovah commented Dec 12, 2021

Hi! thanks for taking the time to write the feature request. I am closing this in favor of #316 where this was already mentioned. Please consider following this issue instead.

@Kovah Kovah closed this as completed Dec 12, 2021
@Fivefold
Copy link
Author

Just for further clarification: I tried out @krylm's snippet from #316 and it seems it aggregates all tags into one (i.e. in my example above you would get one tag test tag1,test_tag2). This is not the behaviour I'm asking for, I don't know how Google Bookmark Manager handles tags though.

Because I'm not too familiar with php and can't debug without setting up a dev environment with LinkAce I will work around by changing all spaces in tags to underscores before import and then changing them back manually in Linkace. I don't have many tags with spaces in them fortunately.

@Kovah
Copy link
Owner

Kovah commented Dec 12, 2021

Yes, I understand. Will keep this in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Any requests for improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants