Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building UserSitemap makes frequent calls to Realm #750

Open
davidsowerby opened this issue Sep 5, 2018 · 0 comments
Open

Building UserSitemap makes frequent calls to Realm #750

davidsowerby opened this issue Sep 5, 2018 · 0 comments

Comments

@davidsowerby
Copy link
Collaborator

The UserSitemapBuilder needs to check that the current user has permission to access a page before adding it to the UserSitemap.

This is done via the UserSitemapNodeModifier and PageController.

However, each authorisation check calls the realm for the user's permissions. This is unnecessary, and could slow things down significantly when permissions need to be retrieved from an external source.

It could also cause confusion if the permissions change while the UserSitemap is being built

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant