Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.2 Compilation errors trying to build in Debug #11

Closed
NerdBird opened this issue Feb 21, 2019 · 4 comments
Closed

Swift 4.2 Compilation errors trying to build in Debug #11

NerdBird opened this issue Feb 21, 2019 · 4 comments

Comments

@NerdBird
Copy link

In the latest swift migration there are two lies of code in #IF DEBUG blocks that weren't migrated along with the rest. This causes compilation errors when trying to build in debug.

I have the fix done locally for normal development, but it would be nice to fix for first pod installs and the like.

The problems are in MemberQuery.swift on line 48 and PredicateBuilder.swift on line 150. Both require changing String(type) to String(describing: type)

@hectormatos2011
Copy link
Contributor

Thanks @NerdBird! I'll merge this right now and submit a release

@hectormatos2011
Copy link
Contributor

Quick update: Apparently, past Hector decided it would be a good idea to convert the library to support type safe key paths and got a new computer since. It's almost done but I'll keep you updated!

@hectormatos2011
Copy link
Contributor

Alright cool it's in master now @NerdBird! I need to run the upload tool for publishing to Cocoapods but it should already start working for Swift Package Manager and Carthage if you're using either of those

@NerdBird
Copy link
Author

Awesome! Thanks, pulling from master now and its all good for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants