Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action extension #10

Closed
wants to merge 1 commit into from
Closed

Add Action extension #10

wants to merge 1 commit into from

Conversation

maicki
Copy link
Collaborator

@maicki maicki commented Nov 25, 2018

Hey Felix,

I was a heavy user of "Mail to Self", but unfortunately as you know it was deprecated. Therefore I love what you started with Major Key.

One thing that is missing for me in MajorKey is to quickly send me links to articles or text snippets from other apps via an extension. Therefore I did a first stab on implementing one. I wanted to open the PR sooner than later to get your feedback and if this is a direction you would be open to go.

Currently the UI is pretty simple and we could leverage the default bottom bar from the main app, but I just thrown in some simple send and cancel button as within the extension you have to add some cancel button to the bottom bar. Replacing the bottom bar should be pretty simple though:

Hope the extension will be helpful.

TODOs:

  • Decide about UI in extension and update it
  • 'App Groups' capability needs to be enabled for the app
  • Enable checking for email set within the extension and show info message to set one up in the main app first
  • Update NSExtensionActivationRule to only contain rules where the extension should show up

@KrauseFx
Copy link
Owner

Hope to have a chance to give this a try this weekend 👍 Thanks for all your hard work

@KrauseFx
Copy link
Owner

KrauseFx commented Dec 3, 2018

Taking a look at it now

@maicki maicki closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants