Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout issues with keyboard predictions #2

Open
kiliankoe opened this issue Nov 27, 2017 · 5 comments
Open

Layout issues with keyboard predictions #2

kiliankoe opened this issue Nov 27, 2017 · 5 comments

Comments

@kiliankoe
Copy link

OMG I've been needing this app for forever. I've been sending myself mails for years and have been playing with a similar idea every now and then, but definitely not quite as streamlined as this is. Thank you! ❤️

I am however running into a bit of a layout issue with the two buttons being obscured behind the keyboard text predictions on my iPhone 6s (not an X 😢).

img_0207

@kiliankoe
Copy link
Author

Oh, just checked. They're positioned absolutely 🙈 Should've had a look at that earlier^^

@KrauseFx
Copy link
Owner

Yeah, I only have an iPhone X, so I'm not gonna fix that (haha, I'm such a nice contributor), but that's why the app is open source, do you want to submit a PR to dynamically position the 🔑 button?

@kiliankoe
Copy link
Author

I just removed both buttons in my locally deployed version instead 🙈😄 The keyboard's done button is perfectly fine^^

@KrauseFx
Copy link
Owner

Haha, yah that works also. Still, if you want to, I'd merge a PR 👍

@patricks
Copy link
Contributor

Should be fixed with that PR 👉 #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants