Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller improvements #8

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Smaller improvements #8

merged 1 commit into from
Nov 28, 2018

Conversation

maicki
Copy link
Collaborator

@maicki maicki commented Nov 24, 2018 •
edited

Just a couple of changes I think could be beneficial, but I'm open to change it to whatever you think it's best.

Changes:

  • Don't add empty text to history
  • Move UITextViewDelegate into a protocol
  • Remove some force unwraps
  • Remove extra whitespace at end

@maicki
Smaller improvements
360b6be 
- Don't add empty text to history
- Move UITextViewDelegate into a protocol
- Remove some force unwraps
KrauseFx
KrauseFx approved these changes Nov 28, 2018
View reviewed changes
Copy link
Owner

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@KrauseFx KrauseFx merged commit eddd48a into KrauseFx:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrauseFx KrauseFx KrauseFx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maicki @KrauseFx