Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNSHealthCheck Controller #106

Closed
Tracked by #105
maleck13 opened this issue Mar 9, 2023 · 2 comments
Closed
Tracked by #105

Add DNSHealthCheck Controller #106

maleck13 opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels

Comments

@maleck13
Copy link
Contributor

maleck13 commented Mar 9, 2023

What

Add a new healthcheck controller under a dns package. This controller is responsible for reconciling the DNSHealthCheck

  • Validate the target and spec of the DNSHealthCheck
  • For each defined listener in the Gateway, add a health check to the DNSRecord ( we can modify the spec of the DNSRecord to support health checks)
  • This controller should be triggered by changes to the DNSRecord, Gateway and DNSHealthCheck resources. DNSHealthCheck should probably be owned by the gateway it is targeting so it is removed if the gateway is removed
  • The status of the DNSHealthCheck should reflect whether the check is considered active
  • Another option is to add a status listener condition that informs that a health check is active for that listener
@maleck13 maleck13 mentioned this issue Mar 9, 2023
3 tasks
@maleck13 maleck13 added this to the m3 Control Plane Tenancy, Policy Support and CI/CD foundation milestone Mar 22, 2023
@sergioifg94 sergioifg94 self-assigned this Apr 3, 2023
@philbrookes
Copy link
Contributor

@sergioifg94 can this be closed now?

@sergioifg94
Copy link
Collaborator

@philbrookes Yep, closing it. Thanks Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants