Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow placement of Gateways #54

Closed
maleck13 opened this issue Feb 2, 2023 · 1 comment
Closed

Allow placement of Gateways #54

maleck13 opened this issue Feb 2, 2023 · 1 comment

Comments

@maleck13
Copy link
Contributor

maleck13 commented Feb 2, 2023

What

As a gateway admin, I want to be able to chose to place a gateway on a set of clusters from my available clusters .

option

use an exact match placement label

kuadrant.io/placement: "key=value"

at a future point we may need more than this simplistic placement logic but this is lightweight.
When a placement is added, the controller needs to figure out which clusters names (secrets) this is selecting. It then needs to add a new label something like: kuadrant.io/<cluster>/placement.decision: "true" which the sync agent will watch for

Done

  • new placement label defined
  • new logic to find the cluster the label matches
  • new logic to add a placement decision to the gateway resource
  • new unit tests
@maleck13 maleck13 added this to the m2 Control Plane Gateways milestone Feb 2, 2023
@maleck13 maleck13 modified the milestones: m2 Control Plane Gateways, m3 Control Plane Policy Mar 9, 2023
@maleck13
Copy link
Contributor Author

An alternative here is to lean into the KCP ideas around placement
https://github.com/kcp-dev/kcp/blob/759f510165a012c28f24c2efbdfc2a258354a21b/config/crds/scheduling.kcp.io_placements.yaml

So allowing to target a resource type and place that resource type on clusters that match the label selectors

@maleck13 maleck13 changed the title Allow placement labels to be applied to Gateways Allow placement of Gateways Mar 22, 2023
@maleck13 maleck13 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done out of iteration
Development

No branches or pull requests

1 participant