Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to add Integrated Dynamics squeezer recipes #297

Open
Hiranus opened this issue Mar 16, 2022 · 5 comments
Open

Impossible to add Integrated Dynamics squeezer recipes #297

Hiranus opened this issue Mar 16, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Hiranus
Copy link

Hiranus commented Mar 16, 2022

Minecraft Version

1.16.5

KubeJS Version

kubejs-forge-1605.3.19-build.299

Rhino Version

rhino-forge-1605.1.5-build.75

Architectury Version

architectury-1.30.53

Forge/Fabric Version

Forge 36.2.28

Describe your issue

I tried adding new recipes to Mechanical Squeezer from Integrated Dynamics but it doesn't work.

e.custom({ type: "integrateddynamics:mechanical_squeezer", item: "minecraft:acacia_leaves", result: { fluid: { fluid: "minecraft:water", amount: 50 }, items: [{ item: 'minecraft:ender_pearl', chance: 0.400 }, { item: 'minecraft:ender_pearl', chance: 0.400 }] }, duration: 15 })

And this is how recipe is shown by JEI, and it also doesn't work in machine itself.
obraz

When something works then items don't have correct chances, fluids are not there etc. Generally it seems like squeezer support code needs a lot of fixing.

Crash report/logs

https://pastebin.com/mnWiZDwG

@ChiefArug
Copy link
Contributor

ID recipes have always been a bit broken, but no ones been able to figure out why...
See CyclopsMC/IntegratedDynamics#995

@Hiranus
Copy link
Author

Hiranus commented Mar 17, 2022

I suspect that issues here are related to your attempt to do a workaround for squeezer bug that makes first output have 100%.
Could you just ignore that for squeezer fix?
When recipes will work properly (item and fluid support) and only thing that would be broken will be that first output thing then pressure will be on IntegratedDynamics side.

@ChiefArug
Copy link
Contributor

Does it work as expected if you add the recipes with the same json in a datapack?

@Hiranus
Copy link
Author

Hiranus commented Mar 25, 2022

Mostly yes.
There is a bug in Integrated Dynamics JEI integration that shows first output with 100% chance (see mentioned issue), but in machine everything works fine. If you are to tackle this kubejs bug then just ignore chance for first output or check it directly in machine.

@Hiranus
Copy link
Author

Hiranus commented Apr 13, 2022

@ChiefArug Seems like Integrated Dynamics author fixed issue with JEI. With that, is there a chance to have this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants