-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell script. #65 #101
Shell script. #65 #101
Conversation
Also @viveknathani should we have a script to stop all of them? I'm not sure if that's used by devs. Let us know what you think/find! @anaswaratrajan PTAL over this PR. I'm looking into the docker PRs. Thanks! |
In order to stop them, you just have to do CTRL+C over them. The way I see it, it is a trivial task. |
We need to run |
yes, right. I was talking about the Node.js servers... |
@manishprivet About the directory structure, you may read the content on this link. |
Yeah I just noticed that, my bad. But correct me if I'm wrong, when we press Ctrl+C, will that close all three processes, or just one? |
Just one. Gotta press three times for the three Node.js servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Can you try running the script from package.json? Either for dev
or a custom run-script
is okay too.
After you're done, please add instructions and necessary notes in the readme file. Thanks!
All right. I made changes in package.json file and README.md file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! :D
Wrote the script required for #65. Please review it.