Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell script. #65 #101

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Shell script. #65 #101

merged 7 commits into from
Mar 10, 2021

Conversation

viveknathani
Copy link
Contributor

Wrote the script required for #65. Please review it.

@anandbaburajan
Copy link
Member

anandbaburajan commented Mar 10, 2021

Also @viveknathani should we have a script to stop all of them? I'm not sure if that's used by devs. Let us know what you think/find! @anaswaratrajan PTAL over this PR. I'm looking into the docker PRs. Thanks!

@viveknathani
Copy link
Contributor Author

Also @viveknathani should we have a script to stop all of them? I'm not sure if that's used by devs. Let us know what you think/find! @anaswaratrajan PTAL over this PR. I'm looking into the docker PRs. Thanks!

In order to stop them, you just have to do CTRL+C over them. The way I see it, it is a trivial task.

@anandbaburajan
Copy link
Member

In order to stop them, you just have to do CTRL+C over them. The way I see it, it is a trivial task.

We need to run sudo systemctl stop mongod to stop mongod, right?

@viveknathani
Copy link
Contributor Author

In order to stop them, you just have to do CTRL+C over them. The way I see it, it is a trivial task.

We need to run sudo systemctl stop mongod to stop mongod, right?

yes, right. I was talking about the Node.js servers...

dev.sh Show resolved Hide resolved
dev.sh Show resolved Hide resolved
@viveknathani
Copy link
Contributor Author

@manishprivet
No. The script does not pause. Line 19 ends with a '&' which pushes the command into the background and allows the remainder of the script to continue.

About the directory structure, you may read the content on this link.
#65 (comment)

@manishprivet
Copy link

@manishprivet
No. The script does not pause. Line 19 ends with a '&' which pushes the command into the background and allows the remainder of the script to continue.

About the directory structure, you may read the content on this link.
#65 (comment)

Yeah I just noticed that, my bad. But correct me if I'm wrong, when we press Ctrl+C, will that close all three processes, or just one?

@viveknathani
Copy link
Contributor Author

@manishprivet
No. The script does not pause. Line 19 ends with a '&' which pushes the command into the background and allows the remainder of the script to continue.
About the directory structure, you may read the content on this link.
#65 (comment)

Yeah I just noticed that, my bad. But correct me if I'm wrong, when we press Ctrl+C, will that close all three processes, or just one?

Just one. Gotta press three times for the three Node.js servers.

Copy link
Contributor

@anastr0 anastr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Can you try running the script from package.json? Either for dev or a custom run-script is okay too.

After you're done, please add instructions and necessary notes in the readme file. Thanks!

@viveknathani
Copy link
Contributor Author

All right. I made changes in package.json file and README.md file.

dev.sh Show resolved Hide resolved
Copy link
Contributor

@anastr0 anastr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :D

@anastr0 anastr0 merged commit b9691bd into samay-app:main Mar 10, 2021
@anastr0 anastr0 linked an issue Mar 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell script to run all the development servers locally
4 participants