Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added PollResponse Through Email #108

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

PushkarDureja
Copy link
Contributor

Fixes #95

I have implemented the code for sending email to the poll creator whenever someone votes on their poll

@anandbaburajan
Copy link
Member

Congrats and thanks!

@anandbaburajan anandbaburajan added enhancement New feature or request gssoc21 labels Mar 12, 2021
@BreadGenie
Copy link
Contributor

@PushkarDureja I'll take a look once I reach home (in couple hours).
Thanks for contributing!

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me except the part where I've commented on

src/components/poll/SubmitChoices.tsx Show resolved Hide resolved
@BreadGenie
Copy link
Contributor

We will merge it once the endpoint is done.
Thanks for the contribution!

@PushkarDureja
Copy link
Contributor Author

Great !!

@anandbaburajan
Copy link
Member

@PushkarDureja have you tested this PR with the new endpoint locally? If yes, we can merge this.

@PushkarDureja
Copy link
Contributor Author

@PushkarDureja have you tested this PR with the new endpoint locally? If yes, we can merge this.

Yes I did it yesterday only after adding back the auth condition.

@anandbaburajan
Copy link
Member

Thanks, merging!

@anandbaburajan anandbaburajan merged commit 389b391 into samay-app:main Mar 17, 2021
@anandbaburajan
Copy link
Member

We've deployed this PR to our site, so can you check out the changes and let us know if everything is fine?

@PushkarDureja
Copy link
Contributor Author

We've deployed this PR to our site, so can you check out the changes and let us know if everything is fine?

Sure, Let me check

@PushkarDureja
Copy link
Contributor Author

@anandbaburajan I don't think it is working!! Did you redeploy the mailer ?

@anandbaburajan
Copy link
Member

@anandbaburajan I don't think it is working!! Did you redeploy the mailer ?

Yup.

@PushkarDureja
Copy link
Contributor Author

PushkarDureja commented Mar 20, 2021

As far as I remember, It was working fine on my local environment. But give me some time to figure it out

@anandbaburajan
Copy link
Member

@AthulJoshi can you share the mailer logs with Pushkar and/or look into it? Thanks!

senderName: newVote.name,
};
sendPollResponse(mailerArgs, token);
}
Router.reload();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After commenting line 57 I took a screenshot of network logs and It shows the pollresponse request is working fine
image

@PushkarDureja
Copy link
Contributor Author

@AthulJoshi I have added a comment, Please have a look

@AthulJoshi
Copy link
Contributor

So, the page is reloading before the request is completed right?

@PushkarDureja
Copy link
Contributor Author

PushkarDureja commented Mar 21, 2021

So, the page is reloading before the request is completed right?

But even if the request has been initiated (which is actually happening, I checked on the live one), Will it depend on the fact, whether the browser is being reloaded or not ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send email notifications to poll creator on new votes
4 participants