Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and linting error fixes #14

Merged
merged 8 commits into from
Jan 5, 2021
Merged

Bug fixes and linting error fixes #14

merged 8 commits into from
Jan 5, 2021

Conversation

VipinVIP
Copy link
Contributor

@VipinVIP VipinVIP commented Jan 5, 2021

  • Fixed AuthUI instance deleted bug
  • Solved the issue of body overflowing Navbar.
  • Fixed linting issues and other minor fixes

Also sorry that i forgot to create a new branch branch 馃槩 .

@VipinVIP VipinVIP requested review from anandbaburajan and anastr0 and removed request for anandbaburajan January 5, 2021 05:47
@anastr0
Copy link
Contributor

anastr0 commented Jan 5, 2021

@VipinVIP Thanks for the fixes! @iamAravindks has removed the AuthUI and replaced with a button and auth functions, so there was no need of that fix. I'm merging

@anastr0 anastr0 merged commit dbd9672 into samay-app:main Jan 5, 2021
@VipinVIP
Copy link
Contributor Author

VipinVIP commented Jan 5, 2021

@VipinVIP Thanks for the fixes! @iamAravindks has removed the AuthUI and replaced with a button and auth functions, so there was no need of that fix. I'm merging

Actually, it was nota firebase error , but something came due to our side 馃槄 .. In the homepage , there were two instances of the Login component , and simply deleting one solved it.

anandbaburajan added a commit that referenced this pull request Mar 2, 2022
Poll API improvements and added Helmet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants