-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boilerplate for Rocketmeet client #3
Conversation
anastr0
commented
Dec 2, 2020
- A basic typescript app is setup with eslint and prettier as mentioned in Client #2.
- Routes for dashboard, help and create a poll are added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anaswaratrajan Thanks! I've added some comments, PTAL.
package.json
Outdated
@@ -0,0 +1,33 @@ | |||
{ | |||
"name": "RocketMeet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename it to rocketmeet
as CAPS are not allowed in the name
@anaswaratrajan If you need any input to continue working on this, please let me know! |
@anandbaburajan I switched to eslint-config-airbnb-typescript, converted all components to const. It took some time to find the right config for eslint to start giving linting errors. Adding @babel/core solved the "JSX not resolved" errors. I also setup react-bootstrap and added a basic layout and landing page as in the wireframe. @VipinVIP Please look into the pr and suggest changes. |
@anaswaratrajan Thanks! The changes look good! One comment: like I asked earlier, aren't you getting any return type missing errors for the React components from ESLint? I checked out this PR, got those errors and fixed one or two by setting |
@anandbaburajan Yep, I'm getting those as warnings. Wasn't sure how to fix it. Thanks! adding |
Merging! Thanks! :D |