Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate for Rocketmeet client #3

Merged
merged 14 commits into from
Dec 25, 2020
Merged

Boilerplate for Rocketmeet client #3

merged 14 commits into from
Dec 25, 2020

Conversation

anastr0
Copy link
Contributor

@anastr0 anastr0 commented Dec 2, 2020

  • A basic typescript app is setup with eslint and prettier as mentioned in Client #2.
  • Routes for dashboard, help and create a poll are added.

Copy link
Member

@anandbaburajan anandbaburajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anaswaratrajan Thanks! I've added some comments, PTAL.

tsconfig.json Outdated Show resolved Hide resolved
package.json Outdated
@@ -0,0 +1,33 @@
{
"name": "RocketMeet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it to rocketmeet as CAPS are not allowed in the name

package.json Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
pages/_app.tsx Outdated Show resolved Hide resolved
pages/_app.tsx Outdated Show resolved Hide resolved
pages/_app.tsx Outdated Show resolved Hide resolved
pages/dashboard.tsx Outdated Show resolved Hide resolved
pages/dashboard.tsx Outdated Show resolved Hide resolved
@anandbaburajan
Copy link
Member

@anaswaratrajan If you need any input to continue working on this, please let me know!

@anandbaburajan anandbaburajan added the enhancement New feature or request label Dec 23, 2020
@anastr0
Copy link
Contributor Author

anastr0 commented Dec 25, 2020

@anandbaburajan I switched to eslint-config-airbnb-typescript, converted all components to const. It took some time to find the right config for eslint to start giving linting errors. Adding @babel/core solved the "JSX not resolved" errors. I also setup react-bootstrap and added a basic layout and landing page as in the wireframe. @VipinVIP Please look into the pr and suggest changes.

@anandbaburajan
Copy link
Member

anandbaburajan commented Dec 25, 2020

@anandbaburajan I switched to eslint-config-airbnb-typescript, converted all components to const. It took some time to find the right config for eslint to start giving linting errors. Adding @babel/core solved the "JSX not resolved" errors. I also setup react-bootstrap and added a basic layout and landing page as in the wireframe. @VipinVIP Please look into the pr and suggest changes.

@anaswaratrajan Thanks! The changes look good! One comment: like I asked earlier, aren't you getting any return type missing errors for the React components from ESLint? I checked out this PR, got those errors and fixed one or two by setting JSX.Element as the return type. Can you please take a look, thanks! I checked out the app and the basic layout looks good too!

@anastr0
Copy link
Contributor Author

anastr0 commented Dec 25, 2020

@anandbaburajan Yep, I'm getting those as warnings. Wasn't sure how to fix it. Thanks! adding JSX.Element as return type fixed those warnings. 👍

@anandbaburajan
Copy link
Member

Merging! Thanks! :D

@anandbaburajan anandbaburajan merged commit 9038e92 into samay-app:main Dec 25, 2020
@anandbaburajan anandbaburajan deleted the spine branch December 25, 2020 14:09
anandbaburajan added a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants