Support SwiftPM (4.1.0) #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nonchalant Thanks for reporting.
I think MirrorDiffKit still can compile on Swift 3.1 (but I confirmed that compiling tests are failed). So, we should support both Swift 3.1 and Swift 4.1 to make compatibility with Swift 3.x if we can. |
|
@Kuniwak I confirmed test is successful on Swift 3.3. Is it OK? $ swift package --version
// Apple Swift Package Manager - Swift 4.1.0 (swiftpm-14050)
$ swift package generate xcodeproj
// Set swift 3.3 manualy
$ swift test // Successful
|
|
@Nonchalant Hmm... This result seems strange, because some tests are not compatible for Swift 3. I'm gonna investigate the cause. |
|
I'm sorry about my tooooooo late reply. I decided to merge it, because If any problems are occured, we can fix it. |
Merged
Kuniwak
added a commit
that referenced
this pull request
Jan 31, 2019
* Support Swift 5 (#41) * Update .gitignore * Update CocoaPods * Migrate to Swift5 * Update README.md * Make CircleCI happy by migrating to Swift 4.2.1 * Try to fix the error from "pod spec lint" Related: CocoaPods/fourflusher#15 * Fix swift_version (#40) * Ready to be v4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Version of MirrorDiffKit is recognized as Swift 3.3 when using by SwiftPM.
I understand Syntax of MirrorDiffKit is Swift 4.1, but SwiftPM doesn't recognize correctly 馃槺
This issue can be resolved by fixing Package.swift to syntax of SwiftPM (4.1.0) 馃殌