Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add how to install development version #333

Closed
wants to merge 2 commits into from
Closed

add how to install development version #333

wants to merge 2 commits into from

Conversation

get-me-power
Copy link
Contributor

Hi!

I added how to install the development version of vint.
Please confirm this Pull Request.

@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #333 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   93.69%   93.69%   -0.01%     
==========================================
  Files         133      133              
  Lines        4158     4155       -3     
  Branches      417      417              
==========================================
- Hits         3896     3893       -3     
  Misses        167      167              
  Partials       95       95

@coveralls
Copy link

coveralls commented Nov 25, 2019

Coverage Status

Coverage decreased (-0.4%) to 95.452% when pulling cc56540 on kazukazuinaina:update_README into 9a239b2 on Kuniwak:master.

@blueyed
Copy link
Member

blueyed commented Dec 27, 2019

Thank you. I've considered merging it, but it should be a) rephrased slightly at least (missing "the"), and b) I've thought that you should know how to install via URLs in general (although that might not be the case when you're not used to pip, of course).
Leaving it open for now.

@get-me-power
Copy link
Contributor Author

I modified the documentation a bit.
How's this?


::

$ pip install git+https://github.com/Kuniwak/vint
$ git clone https://github.com/Kuniwak/vint
$ setup.py install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the first variant is actually better/easier, no?
(this one would also need a cd vint)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.

How's this?

$pip install git+https://github.com/Kuniwak/vint

or

$ git clone https://github.com/Kuniwak/vint
$ cd vint
$ setup.py install

So feel free to close it in case you do not want to adopt it.

@get-me-power
Copy link
Contributor Author

I close this pull request once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants