Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to change the color for other items apart from title #2

Closed
laurentyew opened this issue Nov 3, 2016 · 14 comments
Closed

how to change the color for other items apart from title #2

laurentyew opened this issue Nov 3, 2016 · 14 comments
Assignees

Comments

@laurentyew
Copy link

using only change the title color for me. how can i change the color for the other items ?

@laurentyew
Copy link
Author

the textcolor as well. thanks!

@J-Jamet
Copy link
Member

J-Jamet commented Nov 3, 2016

Hello, I plan to change the color selection in the next version. I do it today. ;)

@J-Jamet J-Jamet self-assigned this Nov 3, 2016
@J-Jamet
Copy link
Member

J-Jamet commented Nov 3, 2016

It's done in v1.0-rc.4. I'll redo the DatePicker and TimePicker in the future for better customization. New version is OK for you ?

@laurentyew
Copy link
Author

awesome , sir , appreciate it a lot!

@J-Jamet J-Jamet closed this as completed Nov 3, 2016
@laurentyew
Copy link
Author

hi sir,

i tried to change the color of the pickers but somehow they are still green and white no matter how i change. i created my own theme but still it doesn't change
screenshot_20161104-103617

@laurentyew
Copy link
Author

my problem. manage to get it working

@J-Jamet J-Jamet reopened this Nov 4, 2016
@J-Jamet
Copy link
Member

J-Jamet commented Nov 4, 2016

TimePicker and DatePicker views are managed by the Android system. I'll create my own views soon, but for now we must change the common value of the theme with colorAccent. :/ I tried to do that this weekend.

@J-Jamet
Copy link
Member

J-Jamet commented Nov 13, 2016

I created a new branch for custom views. We can change the styles of all elements, it will be over in a few days. :)

@J-Jamet
Copy link
Member

J-Jamet commented Nov 28, 2016

You can now apply the style you want to most components :)

@J-Jamet J-Jamet closed this as completed Dec 10, 2016
@laurentyew
Copy link
Author

thanks for the effort! appreciate it . but somehow it seems like it does not get overwritten

here is my style
image

@laurentyew
Copy link
Author

but the color did not change.

i have 2 button below. but they cannot be seen because text color is white. it seems to be taking the color from my custom theme with textcolor attribute. Any way to overwrite that?

image

@J-Jamet
Copy link
Member

J-Jamet commented Jan 3, 2017

To overwrite button text color, you can redefine a style only for activity who contains Dialog or make a dark theme. These are the first ways... I have to change that but no time.

@laurentyew
Copy link
Author

laurentyew commented Jan 4, 2017

i think the issue happens with nougat , as i have tried with textcolor and it doesn't work.

this is a workaround :
using "buttonBarButtonStyle"

<style name="dialog" parent="Base.Theme.AppCompat.Light.Dialog.Alert"> ... @style/DialogButtonStyle ... </style>
<style name="DialogButtonStyle" parent="@style/Widget.AppCompat.Button.ButtonBar.AlertDialog">
    <item name="android:textColor">@color/black</item>
</style>

@J-Jamet
Copy link
Member

J-Jamet commented Jan 5, 2017

Hi, for change text color of button's dialog, you need to change
colorAccent attribute in your style.

Example :

<style name="DialogActivityStyle" parent="Theme.AppCompat.Light.DarkActionBar">
    <item name="colorAccent">@color/colorAccent</item>
    <item name="android:colorAccent">@color/colorAccent</item> <!-- for API > 21 -->
</style>

@J-Jamet J-Jamet closed this as completed Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants