Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cssVar not exported in react-native 0.7 #48

Closed
mattmo opened this issue Jul 7, 2015 · 8 comments
Closed

cssVar not exported in react-native 0.7 #48

mattmo opened this issue Jul 7, 2015 · 8 comments

Comments

@mattmo
Copy link

mattmo commented Jul 7, 2015

Details: facebook/react-native#1821

As a result, cssVar references should be removed from this module:

https://github.com/Kureev/react-native-navbar/blob/master/index.js#L15
@Kureev
Copy link
Owner

Kureev commented Jul 7, 2015

Damn, I got issue about support 0.6.0 1 week ago. They're freaking fast.

@chirag04
Copy link
Contributor

chirag04 commented Jul 7, 2015

+1. Just got hit by this. @Kureev can we remove dependency on cssVar and put those colors in the code directly?

@Kureev
Copy link
Owner

Kureev commented Jul 7, 2015

Sure we can. Want to make a PR, @chirag04 / @mattmo ?

@chirag04
Copy link
Contributor

chirag04 commented Jul 7, 2015

I can PR. Will do it in some time.

@Kureev
Copy link
Owner

Kureev commented Jul 7, 2015

Perfect, looking forward for it

@chirag04
Copy link
Contributor

chirag04 commented Jul 7, 2015

#49

@Kureev
Copy link
Owner

Kureev commented Jul 7, 2015

0.5.3 contain this fix, thanks @chirag04

@Kureev Kureev closed this as completed Jul 7, 2015
@mattmo
Copy link
Author

mattmo commented Jul 8, 2015

Great, thanks guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chirag04 @mattmo @Kureev