Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full Bootstrap and FontAwesome support #29

Open
KurzonDax opened this issue Sep 27, 2013 · 14 comments
Open

Add full Bootstrap and FontAwesome support #29

KurzonDax opened this issue Sep 27, 2013 · 14 comments
Assignees

Comments

@KurzonDax
Copy link
Owner

No description provided.

@ghost ghost assigned KurzonDax Sep 27, 2013
@sinfuljosh
Copy link

I was working on this with alpha and I need to go and rework the theme big time. I was also doing boilerplate with modernizr but its only half in place. let me know if you want help on that and with smarty.

@KurzonDax
Copy link
Owner Author

Oh man, Smarty has probably been my biggest challenge with working on this as I had never used it before. I'm not a huge fan of it so far, but it's functional and does the job lol. Did you do the original Alpha theme or were you just updating/fixing it?

@sinfuljosh
Copy link

Smarty is easy for me cause I'm a design guy n I've spent lots looking into smarty and yes I'm alpha theme and slate theme and poster wall and few other tricks

@KurzonDax
Copy link
Owner Author

Awesome. I used Alpha as the jumping off point for what will be nZEDbetter's new "default" theme, Cyborg. You did a great job with it and obviously put a ton of work in to it. I haven't really done much to overall design of the theme (on the frontend anyway) other than color changes and some minor table layout changes. I've done a bunch of modifying to the Admin section though, which I think everyone will like as it updates the look. More importantly, though, it adds functionality that previously had to be done through phpMyAdmin, or a MySQL command line.

@sinfuljosh
Copy link

Yeah I started with prerelease of BS3 then after many updates that kept breaking it. It needs an overhaul.

The good thing is that I have found some grate framworks of bootstrap 3 that I plan on integrating. if you are online hit me up at sinfuljosh@me.com and if you have IM or aim or on one of the IRCs id love to take a look. I had some grate ideas for admin but help back getting the front end overhauled.

@KurzonDax
Copy link
Owner Author

Here's a few screenshots of what I've done with group management.
image

The sort icons now sort the entire result set, instead of just what's on the current page. Adding groups, including bulk-add are now in a modal dialog. The only major function that I haven't added that I want is a "group edit" feature. It won't take much to do it, just haven't gotten that far yet.

image

Sample of the inline editing:
image

image

Advanced Search modal. I decided to do a modal here due to the number of fields and wanting to limit the available search operators explicitly (to simplify the code). It would have been too much for an accordion drop down I think. I don't really like the look of it right now though, but it's what I'm going with for now.

image

The newsgroups management is where I've done the most work. I've also done some updating to the site settings and tmux-settings pages. The other pages still look pretty much the same except for the header and new menu system. I'm going to get back to working on the MusicBrainz integration next and come back and finish up Admin later on.

@sinfuljosh
Copy link

Looks good. I had same ideas about inline editing and modals. I like the tooltips also . Daft would like to work with you this. I think this with alpha style would be something worthwhile.

Are you heavily modifying the base bootstrap css or making a secondary css to overwrite the defaults?

I had the idea of keeping the base css untouched and working on a "style.css" to modify it. This would allow for a drop in bootswatch type style change.

These changes in the pics are in your current commit?

@KurzonDax
Copy link
Owner Author

I don't touch the base bootstrap css. I use a separate .css to override. However, I must admit that as I was working on it, I wasn't too focused on worrying about accommodating themes in the admin section, so there's quite a few custom classes in addition to the base bootstrap ones. There's also a crap load of jQuery pulling it all together.

All of this will be in the current commit a little later tonight. I changed out the selects on the Advanced Search dialog with a plug-in, despite my misgivings about doing so. I wasn't happy with the styling of the text in the default select drop down, so I gave in and resorted to the plug-in.

image

One other thing I haven't mentioned is that on the groups page, I now use ajax to handle all queries, and then have smarty re-render the group_list div and just replace it in the document. I'm thinking on the front-end about doing something similar. It speeds things up a bit on slow internet connections since it doesn't have to make a bunch of requests for style sheets and scripts, and it would (theoretically) place less load on the server by not having to render the entire page every time someone does a search, or clicks a link on the pager. The downside is it means more tpl's to maintain.

@sinfuljosh
Copy link

Yeah Jquery and ajax is still new to me so havnt been able to get that like you have.

there is a way in smarty when applied properly that smarty can cache most the page and only load whats needed. also in similar fashion .. a proper pagination can cache a full query as a static array to pull from

@KurzonDax
Copy link
Owner Author

Yeah, I tossed around the idea of caching the full query, but haven't really invested much time in to it. I was mainly interested in using ajax for it as an experiment for the front-end. With the potentially huge data sets involved with queries on the front-end, it probably isn't feasible to cache the whole thing, at least not all the time. On the admin back-end though, it makes sense.

@sinfuljosh
Copy link

http://www.smarty.net/forums/viewtopic.php?p=82579&sid=3f6d170c56b5d3094eab228cdd197ede

There's some info about pagination with smarty.

One day soon I wanna sit down via chat and collaborate with you on front end stuff. I wanna fine tune smooth it out.

@KurzonDax
Copy link
Owner Author

Yeah, let's do that. I should have the new install stuff done today, or tomorrow at the latest. Just depends on how work goes today. Once I've got that done, you should be able to fully setup what I've done so far on your own to take a look at.

@sinfuljosh
Copy link

So ... guess what... IM BACK.. after months of hell at work and... will its still hell.. im finally to a stable point that I can come play with the big kids.

Also. Im installing this on a vm to get an idea of how yours looks and works... I have a couple of notes... like when installing it on a server build instead of desktop build theres some changes with the install.. and I still dont recommend the 777 route. but thats the administrator in me.

@KurzonDax
Copy link
Owner Author

Welcome back man! I know how the work thing can be.

I am currently working on a pretty significant update that will be done in 2-3 weeks. Got derailed in December pretty bad due to a family thing and the holidays, so got almost nothing done. But I'm pouring every spare minute in to it now. The new update has a bunch of bug fixes in it, plus MusicBrainz will be complete. I've also rewritten the movie matching stuff and it works way better now.

On the installer, I reworked the setup script a while back, but I didn't mess with the permissions stuff yet. I agree about using 777, but just haven't made the time to make the appropriate changes and test with it. I also haven't really tested on a server version of Ubuntu. Definitely open to any feedback you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants