Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: CollaSet supports operationDelaySeconds #183

Closed
wu8685 opened this issue Apr 2, 2024 · 1 comment
Closed

FeatureRequest: CollaSet supports operationDelaySeconds #183

wu8685 opened this issue Apr 2, 2024 · 1 comment
Assignees

Comments

@wu8685
Copy link
Collaborator

wu8685 commented Apr 2, 2024

Is your feature request related to a problem? Please describe:

After preparing finished in PodOpsLifecycle, we still want to hold CollaSet process for a while before it delete or update Pods, in order to provide a grace period.

Describe the feature you'd like:

When preparing finished in PodOpsLifecycle, it is supposed to hold for a while before CollaSet does operation on Pods. Take traffic for example, after traffic turned off, CollaSet need to wait for seconds before delete Pods to allow the traffic on the fly to be processed.

Describe alternatives you've considered

Option 1 is to use Pod terminationGracePeriod, but it ask for users to handle TERM signal in application codes.
Option 2 is to ask users to consider the graceful process in preparing phase. For example, remove the PodOpsLifecycle protection finalizer only if all the traffic is processed completely.

All of above options ask users for extra effort. We still need to provide a way to make it easier.

Teachability, Documentation, Adoption, Migration Strategy

No response

@ColdsteelRail ColdsteelRail self-assigned this May 21, 2024
@ColdsteelRail
Copy link
Collaborator

lifecycle.allowOps already support operationDelaySeconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants