Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: deleting CollaSet is blocked #184

Closed
wu8685 opened this issue Apr 3, 2024 · 0 comments · Fixed by #216
Closed

Bug: deleting CollaSet is blocked #184

wu8685 opened this issue Apr 3, 2024 · 0 comments · Fixed by #216
Assignees
@wu8685
Labels
kind/bug Something isn't working

Comments

@wu8685
Copy link
Collaborator

wu8685 commented Apr 3, 2024

Minimal reproduce step

There is a probability of being blocked when deleting a CollaSet with at lease one Pod.

Following codes may have problems:

  1. When ownedIDs is empty, UpdateToPodContext will do nothing, instead of cleaning the ResourceContext.
  2. CollaSet also need to watch resource ResourceContext.

What did you expect to see?

PodContext needs to be clean up, and CollaSet will then be deleted successfully.

What did you see instead

PodContext has not been deleted, holding Pod IDs, so that CollaSet will not be deleted.

What is your KusionStack components and its version?

v0.3.0
@wu8685 wu8685 added the kind/bug Something isn't working label Apr 3, 2024
@wu8685 wu8685 self-assigned this Apr 3, 2024
@wu8685 wu8685 mentioned this issue Jun 4, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wu8685 wu8685

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CollaSet): clean up PodContext if it is empty wu8685/operating
1 participant
@wu8685