Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jobs from Services #35

Open
FuzzicalLogic opened this issue May 21, 2019 · 0 comments
Open

Remove Jobs from Services #35

FuzzicalLogic opened this issue May 21, 2019 · 0 comments

Comments

@FuzzicalLogic
Copy link
Contributor

This is a composite issue: There will be specific issues for each Job, so that they may be tracked as each is completed.

A service is/should be a set of functionality that is (typically openly) available for clients and consumers to use. In the circumstance of JobsService, it is combined with several other (current) services that are simply tasks performed at specific intervals. The list includes RssService, Leaderboards Service and StreamsService.

There is little reason to keep these available as a Service as they completely encapsulate their work process. In fact, they are more cleanly defined as Workers rather than Services. Redefining them as Workers, rather than Services will allow more SOLID architecture, cleaner instancing, lighter memory usage, and better reporting. It will also facilitate looser coupling, testing/mocking, and will allow event-based processing. Finally, it will accommodate issues similar to #30 and #31 much more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant