Swift 4.2 compatibility #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @KyoheiG3, just wanted to bump this. Is there a chance this will be merged anytime soon? My library https://github.com/Orderella/PopupDialog depends on it and I would love to keep it updated. If you are not maintaining this library anymore, please give me shout. Thanks, mate! |
|
Hi. I am using this library as well. It would be fantastic if this could all be merged. |
|
Hi @mwfire |
|
@KyoheiG3 could we get the Podspec version updated so the latest can be pulled? Thanks! |
|
@pushchris I updated just now. |
|
Thanks a lot @KyoheiG3! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the upcoming official Swift 4.2 release, this PR incorporates the changes needed to support 4.2.
Before the official release, I would recommend to merge this PR to a dedicated Swift 4.2 branch, which I am not able to do :)
I did not bump version, though, as I think you have a better understanding on how you want to version DynamicBlurView.
Hope that makes sense :)