Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tests to Swift 5 #11

Merged
merged 2 commits into from Aug 29, 2019
Merged

Upgrade Tests to Swift 5 #11

merged 2 commits into from Aug 29, 2019

Conversation

Nonchalant
Copy link
Contributor

Hi, Author.

I upgraded Tests to Swift 5 to conform with swift version of production code.
But, I cannot confirm TravisCI. Please check test success or failure in ci.

@KyoheiG3
Copy link
Owner

Hi @Nonchalant
Please change the script on .travis.yml to the following:

-  - xcodebuild test -project ./GridView.xcodeproj -scheme GridViewTests -configuration Debug -sdk iphonesimulator -destination 'platform=iOS Simulator,id=ABBD7191-486B-462F-80B4-AE08C5820DA1' | xcpretty -c
+  - xcodebuild test -project ./GridView.xcodeproj -scheme GridViewTests -configuration Debug -sdk iphonesimulator -destination 'platform=iOS Simulator,OS=12.4,name=iPhone 8' | xcpretty -c

@KyoheiG3
Copy link
Owner

Perfect.
Thank you!

@KyoheiG3 KyoheiG3 merged commit 624a19a into KyoheiG3:master Aug 29, 2019
@Nonchalant Nonchalant deleted the upgrade-tests-to-swift5 branch August 30, 2019 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants