Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't modify message text #14

Closed
grantism opened this issue Mar 9, 2016 · 3 comments
Closed

can't modify message text #14

grantism opened this issue Mar 9, 2016 · 3 comments

Comments

@grantism
Copy link

grantism commented Mar 9, 2016

After initializing a simpleAlert controller, it is possible to change the title, but it is not possible to change the message.

This works:
let alert = SimpleAlert.Controller(title: "blah", message: "blah", style: .Alert)
alert.title = "changed it"

But this doesn't:
let alert = SimpleAlert.Controller(title: "blah", message: "blah", style: .Alert)
alert.message = "changed it"

For consistency & flexibility, it should be possible to set the message value in the same way as the title.

@KyoheiG3
Copy link
Owner

Oh, Sorry, It is a bug that title can be changed. Do you need the property to change message?
Thanks.

@grantism
Copy link
Author

grantism commented Apr 4, 2016

That makes sense. I was coming from the point of view of the standard UIAlertController & other UI items which allows changing the title and message properties after initialisation (More as a point of keeping consistency with other UI elements than anything else).

I suppose this issue should be 'Don't allow modification of title after initialisation' instead :)

@KyoheiG3
Copy link
Owner

Message text became to be able to modify in #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants