Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
LegoColor(r:g:b:)
の処理に時間がかかるため、rgb の値をキーとしてキャッシュするようにしました。私のアイコンを
StudType: Round
・Max Stud: 128
で試したところ、処理時間が約 1/33 になりました。同じ色を使っている画像ほど処理が速くなります。
逆にほぼ異なる色だと、キャッシュを捜査する分だけ処理が遅くなりますが、具体的な時間は計測していません。
処理時間の計測は
colorMap
生成の前後に以下を仕込んで行いました。Before
After