Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify theme support #18

Closed
rvibit opened this issue Dec 16, 2022 · 3 comments
Closed

Verify theme support #18

rvibit opened this issue Dec 16, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@rvibit
Copy link
Contributor

rvibit commented Dec 16, 2022

Any plan to merge this PR ?

gnikyt/laravel-shopify#1198
@Kyon147
Copy link
Owner

Kyon147 commented Dec 18, 2022

I can look to merge it in but it would need to be remade again on this repo.

If someone creates the PR again, I will take a look at it 👍

@Kyon147 Kyon147 added the help wanted Extra attention is needed label Dec 18, 2022
@rvibit rvibit mentioned this issue Jan 26, 2023
Merged
@joeelia
Copy link

joeelia commented Jan 26, 2023

Just a note that this is only applicable for already listed apps. Any new apps will be required to only use App Extensions
https://shopify.dev/apps/online-store/theme-app-extensions/update#migrate-your-apps

Screen Shot 2023-01-26 at 3 19 08 PM

@sp-artisan sp-artisan mentioned this issue Feb 16, 2023
Closed
@Kyon147
Copy link
Owner

Kyon147 commented Jun 16, 2023

v19.0.0 now solves this issue.

@Kyon147 Kyon147 closed this as completed Jun 16, 2023
@h6code h6code mentioned this issue Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kyon147 @joeelia @rvibit