Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unsol Loss detection #126

Closed
christophe-calmejane opened this issue Jan 6, 2023 · 1 comment
Closed

Improve Unsol Loss detection #126

christophe-calmejane opened this issue Jan 6, 2023 · 1 comment
Labels
bug Something isn't working controller Controller Library high priority High priority issue
Milestone

Comments

@christophe-calmejane
Copy link
Contributor

The algorithm may cause some unexpected behaviors

@christophe-calmejane christophe-calmejane added bug Something isn't working controller Controller Library high priority High priority issue labels Jan 6, 2023
@christophe-calmejane christophe-calmejane added this to the Release 3.4.1 milestone Jan 6, 2023
@christophe-calmejane
Copy link
Contributor Author

The controller always expect 0 as first unsol for Milan device (as the spec says). The issue is that if the controller restarts (quickly) without properly deregistering first, the device cannot detect the controller restarted (even though it's sending a new REGISTER_UNSOL, because the Milan spec doesn't specify the counter should, or not, reset), and will continue sending unsol using its current sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working controller Controller Library high priority High priority issue
Projects
None yet
Development

No branches or pull requests

1 participant