Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCV dependency #3

Closed
drinkingkazu opened this issue Apr 30, 2016 · 1 comment
Closed

OpenCV dependency #3

drinkingkazu opened this issue Apr 30, 2016 · 1 comment
Assignees

Comments

@drinkingkazu
Copy link

There are inconsistency handling of OpenCV dependency.
Original intent (which I plan to follow) is:
0) shell environment variable OPENCV_INCDIR and OPENCV_LIBDIR must be defined each pointing to a conventional top directory path to headers and libraries of opencv.

  1. when 0) is satisfied, configure.sh sets LARCV_OPENCV environment variable to 1 (or 0 otherwise). This should be used in package makefile to judge whether or not to use OpenCV.

Issue made apparent by Tari: we should set a compiler variable to set compiler guards in source codes.

@drinkingkazu
Copy link
Author

Now fixed:

a) Build system put -DUSE_OPENCV if $LARCV_OPENCV is set to 1.
b) larcv-config --libs now automatically appends "-L${OPENCV_LIBDIR} -lopencv_core -lopencv_highgui -lopencv_imgproc -lopencv_imgcodecs"
c) modified relevant package GNUmakefile to just use LDFLAGS += $(shell larcv-config --libs)
d) modified relevant source code to use a compiler guard statements for CV related part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant