Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falsecolor? #29

Closed
sariths opened this issue Oct 22, 2023 · 1 comment · Fixed by #31
Closed

Falsecolor? #29

sariths opened this issue Oct 22, 2023 · 1 comment · Fixed by #31
Labels
question Further information is requested

Comments

@sariths
Copy link
Collaborator

sariths commented Oct 22, 2023

Hi @taoning, I was trying to create an workflow when I ran across the issue of missing falsecolor. Is this intentional? I understand that here you have shown an example of creating a falsecolor image.

It does seem like jumping around hoops to recreate a functionality that is almost integral to Radiance. For the past year (or earlier), falsecolor, genBSDF etc. (all perl based) are being compiled as binaries(exe) on my Windows machine. Since you are already distributing genBSDF, isn't it straightforward to distribute falsecolor also?

Btw, I am stating all this because up until one runs into the falsecolor issue, one can work with pyradiance seamlessly without any dependencies.

@sariths sariths added the question Further information is requested label Oct 22, 2023
@taoning
Copy link
Collaborator

taoning commented Oct 22, 2023

We can certainly add falsecolor. All we need to do is add a falsecolor function in px.py. Then add falsecolor to the list of binaries in setup.py. expose falsecolor function in init.py
PR welcomed :)

This was referenced Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants