Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General concerns with code quality #968

Open
sudokoko opened this issue Jan 19, 2024 · 4 comments
Open

General concerns with code quality #968

sudokoko opened this issue Jan 19, 2024 · 4 comments
Labels
priority:high server:api server:gameserver server:website tracking issue This issue serves as a tracking point for potential code changes

Comments

@sudokoko
Copy link
Member

There are some concerns regarding uniformity of code quality throughout the project. This issue will serve as a discussion point for possible solutions and as a tracking point for related PRs.

@sudokoko sudokoko added priority:high server:website server:gameserver server:api tracking issue This issue serves as a tracking point for potential code changes labels Jan 19, 2024
@sudokoko sudokoko pinned this issue Jan 19, 2024
@m88youngling
Copy link
Contributor

to quote slendy

"it's time for lighthouse 2"

anyway, what specific concerns do we have with the code quality?

@sudokoko
Copy link
Member Author

Generally, the code quality throughout the project is not uniform and uses a variety of styles. A good first step to resolve this could be to set up a CI linter for pull requests. We could decide on an optimal linter configuration through discussion, as well as maybe fine-tuning our DotSettings file, and have a passing linter be a requirement for PR merge.

@m88youngling
Copy link
Contributor

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

@sudokoko
Copy link
Member Author

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

Yes, that is what a linter does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high server:api server:gameserver server:website tracking issue This issue serves as a tracking point for potential code changes
Projects
None yet
Development

No branches or pull requests

2 participants