Fix/optimization fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnation3406
approved these changes
Jul 20, 2019
| @@ -77,4 +77,4 @@ class ConfigurationStatusFilter(django_filters.FilterSet): | |||
|
|
|||
| class Meta: | |||
| model = ConfigurationStatus | |||
| fields = '__all__' | |||
| fields = ('guide_camera_name',) | |||
There was a problem hiding this comment.
what about instrument name?
There was a problem hiding this comment.
Instrument name is included as a filterable field since it is declared in the filterset a few lines up
| @@ -91,10 +91,12 @@ def proposal_title(self, obj): | |||
|
|
|||
| class ProposalInviteAdmin(admin.ModelAdmin): | |||
| model = ProposalInvite | |||
| raw_id_fields = ['proposal'] | |||
There was a problem hiding this comment.
do raw_id_fields still give you a link to that admin object?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the slow
/api/configurationstatus/endpoint was its filter. For a filterset, if a field that is a foreign key is included, the default filter that is used is aModelChoiceFilter, which generates all the options for that field. So it's pretty slow on big tables.The admin target change page was slow for a similar reason. The associated configuration is displayed on the page, and by default django will generate a dropdown with all options so that the user can update the associated configuration. Using
raw_id_fieldshelps that.