Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target extra params #56

Merged
merged 2 commits into from Jul 22, 2019
Merged

Fix target extra params #56

merged 2 commits into from Jul 22, 2019

Conversation

eheinrich
Copy link
Member

Target extra params were not included in serialized responses. Also added vmag and radvel to request shim submission.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.154% when pulling f4f3535 on fix/target-extra-params into 429ae87 on master.

Copy link
Member

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine... did someone encounter an error trying to submit these? I thought that they were not being used at all. Even if they get through the response, I don't think site software uses them for anything

@eheinrich
Copy link
Member Author

Yes, neoexchange submits vmag via the shim, which was not getting through.

@jnation3406
Copy link
Member

oh yeah, I forgot NEOx coopted this NRES feature and started using it for tracking non sidereals... good catch

@eheinrich eheinrich merged commit 94cbc49 into master Jul 22, 2019
@eheinrich eheinrich deleted the fix/target-extra-params branch July 22, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants