Feature/update scicollab alloc #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnation3406
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Looks good, great job! We might want to change the names of the LCO telescopes to 1 Meter LCO or something in configdb before deploying this, because once it is deployed and names set, they won't auto-update if we change them. Also we gotta make sure to record what the current values are for the SCAs before deploying the change since it deletes those fields - the dev one is probably good enough for this because they don't really change
|
Good call! I've updated all of the names in configdb. And yeah, I'll double check the values before deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, the allocations are by telescope name and the telescope options in the form are populated from configdb.
This is running on my machine for testing.