Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ongoing design considerations #92

Closed
stelmo opened this issue Apr 16, 2021 · 2 comments
Closed

Ongoing design considerations #92

stelmo opened this issue Apr 16, 2021 · 2 comments
Assignees

Comments

@stelmo
Copy link
Collaborator

stelmo commented Apr 16, 2021

From our discussion today via Slack (@exaexa @laurentheirendt):

  1. LinearModel -> CoreModel
  2. Creation of SBMLModel, MATModel, JSONModel, (maybe YAMLModel?) types to store models read in from those files. Use all fields supported by the various file types.
  3. Analysis functions should work on all model types. Input: model type. Output: numbers etc.
  4. Reconstruction functions will output StandardModel or CoreModel depending on the input type with restrictions on which type of model depending on the purpose of the reconstruction functions
  5. Squashing models: example: CoreModel and SBMLModel can at most output a CoreModel
  6. Reconstruction functions will have as an input StandardModel or CoreModel
  7. accessors rather than deep copies when converting model types
@stelmo
Copy link
Collaborator Author

stelmo commented Apr 29, 2021

I think this will be done after #126 is merged?

@exaexa
Copy link
Collaborator

exaexa commented Apr 29, 2021

👍 the main idea of this issue is in, safe to close then. :D

@exaexa exaexa closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants