Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule with special classes for Arbor and Neuron/LFPy+pt3d #179

Open
espenhgn opened this issue Apr 12, 2022 · 1 comment · May be fixed by #181
Open

Add submodule with special classes for Arbor and Neuron/LFPy+pt3d #179

espenhgn opened this issue Apr 12, 2022 · 1 comment · May be fixed by #181
Assignees
Labels
enhancement New feature or request no-issue-activity
Milestone

Comments

@espenhgn
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The 3D geometry of a neuron model can be represented by an arbitrary number of data points (typically coordinates/diameter x, y, z, d along cable segments), while the number of electric compartments (or CVs in Arbor terms) may be more or less.
In "old" LFPy we considered only the start- and endpoint of straight-line electric compartments, while one can distribute transmembrane currents along the chain of frusta making up each compartment.
This functionality is exemplified e.g., in https://github.com/LFPy/LFPykit/blob/master/examples/Example_LFPy_pt3d.ipynb

Describe the solution you'd like
We could package inherited CellGeometry classes (for Arbor, Neuron, LFPy+pt3d) which track which frusta belong to each compartment, as well as slightly modified get_transformation_matrix methods for the different classes in lfpykit.models (see above notebook).

@espenhgn espenhgn added the enhancement New feature or request label Apr 12, 2022
@espenhgn espenhgn added this to the Release 0.5 milestone Apr 12, 2022
@espenhgn espenhgn self-assigned this Apr 12, 2022
@github-actions
Copy link

This issue appears to be stale due to non-activity and will be closed automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant