This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
refactor(windows-rs): upgrade to 0.9.1 and handle all breaking changes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was probably the least fun upgrade I've ever done of a dependency. Many imports moved packages, contants were changed to associated constants, and the linker refused to work with wildcards in the build.rs file of the bindings package. This commit is the result of patiently going through each error reported by rustc, cross referencing with the new windows-rs docs and updating / making things more semantic where it seemed like the right thing to do. I am running this commit locally for a few days to see if any regressions have been introduced, but it seems like everything is alright at first glance.
|
@eramdam If you're still using yatta and you have time it would be great if you could also try running this build and keep an eye out for any regressions that may have been introduced! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was probably the least fun upgrade I've ever done of a dependency.
Many imports moved packages, contants were changed to associated
constants, and the linker refused to work with wildcards in the build.rs
file of the bindings package.
This commit is the result of patiently going through each error reported
by rustc, cross referencing with the new windows-rs docs and updating /
making things more semantic where it seemed like the right thing to do.
I am running this commit locally for a few days to see if any
regressions have been introduced, but it seems like everything is
alright at first glance.