Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

"Real world" testing for transaction building and coin selection #30

Open
evanlinjin opened this issue Oct 6, 2022 · 0 comments
Open
Labels
testing For quality assurance

Comments

@evanlinjin
Copy link
Collaborator

evanlinjin commented Oct 6, 2022

Firstly, we need tests to check whether weight calculations are correct for coin selector. I would do this with different descriptors, and attempt to "sign" with "max satisfaction weight".

  • Generate a Selection result.
  • Construct tx with that result (that is signed).
  • Compare weight of final tx with calculations of the CoinSelector::weight* methods.

It will be awesome, if we can pass our raw tx to Bitcoin Core RPC (or something) to verify further.

We also need tests that ensure "minimum drain value" are correct, so that tx will not be rejected for having a dust output.

What other tests do we need?

@evanlinjin evanlinjin added the good first issue Good for newcomers label Oct 11, 2022
@evanlinjin evanlinjin removed the good first issue Good for newcomers label Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing For quality assurance
Projects
Status: Todo
Development

No branches or pull requests

1 participant