Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make API of op::lincomb not require collecting first #125

Closed
LLFourn opened this issue Oct 6, 2022 · 1 comment · Fixed by #170
Closed

Make API of op::lincomb not require collecting first #125

LLFourn opened this issue Oct 6, 2022 · 1 comment · Fixed by #170

Comments

@LLFourn
Copy link
Owner

LLFourn commented Oct 6, 2022

see #116
@LLFourn LLFourn mentioned this issue Oct 6, 2022
Closed
@LLFourn
Copy link
Owner Author

LLFourn commented Dec 14, 2022

So I tried to do this just now. The problem I ran into is that you can't really take an IntoIterator<Item=impl Borrow<Something>> and then map Something to a property of it (which we need to do here to get the backend scalar/point). We could take an Iterator and map it but not an IntoIterator since we can't borrow from each iteration. Making it take plain Iterator would solve the issue @sanket1729 was having but seems like it would make the API more clunky where you want to pass in a vector without calling into_iter yourself.

Opting to leave it like it is now until we think of some way of doing both.

@LLFourn LLFourn mentioned this issue Jan 5, 2023
Closed
@LLFourn LLFourn mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use procedural macro for g! and s! macros LLFourn/secp256kfun
1 participant
@LLFourn