Skip to content
This repository has been archived by the owner on Sep 3, 2019. It is now read-only.

Added a default implementation for the username block when offline #185

Merged
merged 1 commit into from
Jul 16, 2014
Merged

Added a default implementation for the username block when offline #185

merged 1 commit into from
Jul 16, 2014

Conversation

nathan
Copy link
Contributor

@nathan nathan commented May 14, 2014

This way the username block appears the correct color:

screen shot 2014-05-14 at 03 30 19

instead of the "unimplemented" color:

screen shot 2014-05-14 at 03 30 50

@sclements
Copy link
Contributor

I'm going to ask the design team about whether the block should even exist in the offline palette. In some environments projects will never be used online and having such a block in the palette makes no sense.

@nathan
Copy link
Contributor Author

nathan commented Jul 16, 2014

@sclements any progress on this?

sclements added a commit that referenced this pull request Jul 16, 2014
Added a default implementation for the username block when offline
@sclements sclements merged commit 266f5ee into scratchfoundation:master Jul 16, 2014
@nathan nathan deleted the implement-username-offline branch July 16, 2014 19:30
@nathan nathan added this to the v422 milestone Aug 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants