-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire sprite info panel to VM #152
Conversation
For the time being, update the position onChange. Eventually this will update onBlur/on "enter" key
Very crude, requires a refactor to allow toggling
Refactor sprite info behavior into a container and let it handle the raw events. TODO: refactor again into redux
Validation of Sprite NamesOne issue that may be ok to resolve later if we file a bug is that it is possible in the PR to have sprites with Negative Integers in X / Y Position FieldsIf you start typing a negative integer (e.g. PerformanceThe performance hit is really quite large and you can feel it while interacting with the GUI (dragging out a block, panning the workspace, adding a sprite, or editing a field) while a simple program is running ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm ok to land this as long as we file bugs for the three issues I listed. I recommend that the negative x/y position issue be resolved before the Friday review.
These aren't necessary to update in realtime, so throttle them to once every 30ms
I fixed the performance issues altogether! Hahahaha! |
And agreed on the other two points. |
Sets up sprite info component to reflect data about the selected sprite in the panel.
In the interest of time:
-
is interpreted as-1
. Eventually this should only happen on blur or enter key pressed. Good luck trying to update position while a sprite is moving 🙃/cc @lifeinchords @cwillisf @carljbowman