Prevent crash when saving locally on iOS 13 safari #5927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
resolves #1783
Proposed Changes
When saving to a local file (file -> save to your computer), wait briefly before removing the download link. This prevents the crash on iOS 13, and the file downloads with a correct filename and extension.
Reason for Changes
Not 100% sure why this works, but it probably prevents a race condition in iOS Safari.
Test Coverage
No tests
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iOS
Android Tablet