Add Thread.StackFrame class #1118
Conversation
src/engine/thread.js
Outdated
| } | ||
|
|
||
| static release (stackFrame) { | ||
| _stackFrameFreeList.push(stackFrame.reset()); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Use a private StackFrame class to help internally manage use of Stack Frame values and memory. Create params, reported, and executionContext on demand.
mzgoddard
force-pushed
the
recycle-stack-frame
branch
from
0fe87f6
to
0634e96
Compare
There was a problem hiding this comment.
In my testing this works great and it makes sense to me. Just a question about the possibility of a memory leak — I'm not sure what the situation would be for frames to be continually added to the recycle bin without being removed, but seems like the kind of thing that could lead to things crashing if left running a long time?
| */ | ||
| static release (stackFrame) { | ||
| if (typeof stackFrame !== 'undefined') { | ||
| _stackFrameFreeList.push(stackFrame.reset()); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Proposed Changes
Use a private StackFrame class to help internally manage use of Stack Frame values and memory. Create params, reported, and executionContext on demand.
Reason for Changes
params, reported and executionContext are created whether a stack frame will need them or not. Creating those members on demand in the stack frame saves time instantiating them and later garbage collecting them.