Use correct name in changeBlock in renameVariable #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Questions:
|
|
Note: I'm holding off on merging this until the next release cycle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves scratchfoundation/scratch-gui#4098
Resolves scratchfoundation/scratch-gui#5256
Resolves scratchfoundation/scratch-blocks#1415
Proposed Changes
When the variable type is list, use
LISTas the name of the field, notVARIABLE.Reason for Changes
The previous code caused the monitor data passed to GUI to have old name, so the list monitor kept the old name. This bug is well-known and several topics have been made on BaG forums.
Test Coverage
Manually tested: