Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure this.workerClass exists before instanceof check #968

Merged
merged 1 commit into from Mar 12, 2018

Conversation

gnarf
Copy link
Contributor

@gnarf gnarf commented Mar 7, 2018

This avoids an error I was running into in a node environment:

TypeError: Right-hand side of 'instanceof' is not an object

This avoids an error I was running into in a node environment:

```
TypeError: Right-hand side of 'instanceof' is not an object
```
Copy link
Contributor

@thisandagain thisandagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisandagain thisandagain merged commit 2ae788c into scratchfoundation:develop Mar 12, 2018
stefania11 pushed a commit to mitmedialab/cognimates-vm that referenced this pull request Mar 31, 2018
Localizes the pen extension:
- loads all pen locale information - may want to consider dynamically loading locales later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants