Merge pull request #7264 from edelfino11/develop

CE-294 Fix(7137) Make the love and favorite icons colorblind friendly
scratchfoundation · Feb 2, 2023 · d94ea58 · d94ea58
1 parent 6d655b4
commit d94ea58
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 7 deletions.
diff --git a/src/components/extension-landing/extension-landing.scss b/src/components/extension-landing/extension-landing.scss
@@ -39,7 +39,7 @@
     .headline-icon {
         height: 40px;
         width: 40px;
-        margin: auto;
+        margin: auto 0;
     }
 
     .download {

diff --git a/src/views/boost/boost.jsx b/src/views/boost/boost.jsx
@@ -34,7 +34,7 @@ class Boost extends ExtensionLanding {
                     renderCopy={
                         <FlexRow className="extension-copy">
                             <h1><img
-                                alt=""
+                                alt="Boost"
                                 className="headline-icon"
                                 src="/images/boost/boost.svg"
                             />LEGO BOOST</h1>

diff --git a/src/views/download/scratch-link/download.jsx b/src/views/download/scratch-link/download.jsx
@@ -31,7 +31,7 @@ const ScratchLink = ({intl}) => {
                         <FlexRow className="column extension-copy">
                             <h1><img
                                 alt={intl.formatMessage({id: 'scratchLink.linkLogo'})}
-                                width="40px"
+                                className="headline-icon"
                                 src="/images/scratchlink/scratch-link-logo.svg"
                             />{intl.formatMessage({id: 'scratchLink.headerTitle'})}</h1>
                             <FormattedMessage id="scratchLink.headerText" />

diff --git a/src/views/ev3/ev3.jsx b/src/views/ev3/ev3.jsx
@@ -39,7 +39,8 @@ class EV3 extends ExtensionLanding {
                     renderCopy={
                         <FlexRow className="column extension-copy">
                             <h1><img
-                                alt="ev3.svg"
+                                alt="EV3"
+                                className="headline-icon"
                                 src="/images/ev3/ev3.svg"
                             />LEGO MINDSTORMS EV3</h1>
                             <FormattedMessage

diff --git a/src/views/ev3/ev3.scss b/src/views/ev3/ev3.scss
@@ -5,6 +5,10 @@
         background-color: $ui-orange;
         background-image: url("/images/ev3/ev3-pattern.svg");
     }
+    .headline-icon {
+        width: 32px;
+        height: 36px;
+    }
     .step-image.tall {
         height: 16rem;
     }

diff --git a/src/views/gdxfor/gdxfor.jsx b/src/views/gdxfor/gdxfor.jsx
@@ -34,7 +34,8 @@ class GdxFor extends ExtensionLanding {
                     renderCopy={
                         <FlexRow className="extension-copy">
                             <h1><img
-                                alt=""
+                                alt="Vernier Force & Acceleration"
+                                className="headline-icon"
                                 src="/images/gdxfor/gdxfor.svg"
                             />Vernier Force & Acceleration</h1>
                             <FormattedMessage

diff --git a/src/views/microbit/microbit.jsx b/src/views/microbit/microbit.jsx
@@ -38,7 +38,8 @@ class MicroBit extends ExtensionLanding {
                     renderCopy={
                         <FlexRow className="extension-copy">
                             <h1><img
-                                alt=""
+                                alt="Microbit"
+                                className="headline-icon"
                                 src="/images/microbit/microbit.svg"
                             />micro:bit</h1>
                             <FormattedMessage

diff --git a/src/views/microbit/microbit.scss b/src/views/microbit/microbit.scss
@@ -7,6 +7,11 @@
         background-image: url("/images/microbit/mbit-pattern.svg");
     }
 
+    .headline-icon {
+        width: 34px;
+        height: 28px;
+    }
+
     .things-to-try {
         .display-hello {
             .step-image {

diff --git a/src/views/wedo2/wedo2.jsx b/src/views/wedo2/wedo2.jsx
@@ -35,7 +35,8 @@ class Wedo2 extends ExtensionLanding {
                     renderCopy={
                         <FlexRow className="extension-copy">
                             <h1><img
-                                alt=""
+                                alt="Wedo"
+                                className="headline-icon"
                                 src="/images/wedo2/wedo2.svg"
                             />LEGO Education WeDo 2.0</h1>
                             <FormattedMessage