-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed projects don't work #1661
Comments
My suspicion is that this is related to Chrome and Firefox tightening their security model. I have reproduced this locally with Chrome 62.0.3202.89 (Official Build) (64-bit) on macOS 10.12.6. When looking at the Security pane from the dev tools for Chrome, I see: Normally all secure content must be loaded from a secure document. However Chrome does not print any console messages related to the attempted load of flash content. Adding |
Well, we won't have to worry about this in Scratch 3.0. |
The strange thing is that it works on the embed website, but not in the iframe. It seems like the iframe is blocking the allowing of flash. |
@Kenny2github I think the problem is that maybe, the files needed to load shockwave don't load correctly. Can you please give me the code for embedding projects so I could help? |
The meta tag blocks iframe embeds. f569d02 is the commit. @Kenny2github |
#862 says that was fixed. |
|
@colbygk Why would a source have a file protocol? It may have something to do with the code I found. |
Wait. Never mind. The protocol was what was used to run the iframe. It used to work on everything though. |
I'm going to use it for MediaWiki, so I can't neither change one's browser settings nor load another JS |
@Kenny2github So here's what I have found. It doesn't work when you load it (got the same error), but when you click on "Site settings" and click "Allow Flash" then it works for me. |
@greenbayrules this would look like a browser issue then - it doesn't show anything about the plugin being blocked, and it doesn't "ask" (which is my default). @colbygk opinions? |
You have to click on the i button.... here let me show you a gif @Kenny2github Sorry for the messed up colors, I use ubuntu, and for some reason all the colors are tinted purple |
Wow! That solution was way simpler than I thought... |
On Chrome, clicking on "this page" or the "get Adobe Flash player" button will make the browser prompt if you want to use Flash. Whether or not Flash is enabled depends on the parent (so even if you have Flash enabled on Scratch, it won't run when embedded in a different domain with Flash disabled) |
I made a Scratch extension that can allow Scratch web creators. I just created a website to embed one of my projects with it. Since it has a Scratch domain, the embedding works automatically. |
@amazinigmech2418 An extension for chrome? |
@amazinigmech2418 Also, please provide the full version string of chrome that you are using. |
@colbygk It's a Scratch extension that is run with a bookmarklet. It's also on ScratchX when you use the link in the ScratchX repo for it. |
@colbygk What do you mean full string? If you mean the version of Chrome, how do you get it? |
Type |
So would it be 63.0.3239.132? @colbygk |
@amazinigmech2418 I think this involves the different permissions the browser has. |
I think it's been established that this is due to the security model updates in Firefox and Chrome. Closing. |
Expected behavior
Embedding projects (
<iframe allowtransparency="true" width="485" height="402" src="https://scratch.mit.edu/projects/embed/178433850/?autostart=false" frameborder="0" allowfullscreen></iframe>
) should workActual behavior
It says "oh no, you don't have flash":
![image](https://user-images.githubusercontent.com/28599280/32546167-1ed1a5c6-c4b9-11e7-8c95-b9754217d835.png)
Steps to reproduce
Operating System and Browser
Windows 10, on Chrome and Firefox - I think it's not an OS issue though.
The text was updated successfully, but these errors were encountered: