Add Logo to join flow standalone page. #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The most narrow window widths look a little awkward:
(emulating mobile:)
But, I think this is strictly better than what we had before, and we could circle back to that in a later design iteration. |
benjiwheeler
previously approved these changes
Sep 24, 2019
Will need some css work, especially for small screens.
picklesrus
force-pushed
the
add-logo-to-join-2
branch
from
f775adb
to
fd131b8
Compare
|
Agreed! It does need some love especially in that smallest case. I'm not sure how to make the modal move down further in the smallest case. Since the logo isn't in the flow of the page adding spacing around it doesn't work. I was trying to avoid modifying the modal css, but maybe I have to? Happy to chat about it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logo links back to scratch homepage.
This will need some positioning css work if we want to match it to teacher registration, especially on small screens. Right now it is set to be 25% of the way across the screen until it gets small when it is set to be centered.